GODRIVER-1930 bsoncore Array functions should return Array #626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjirewis
commented
Mar 29, 2021
benjirewis
commented
Mar 29, 2021
divjotarora
approved these changes
Mar 30, 2021
iwysiu
approved these changes
Mar 31, 2021
kevinAlbs
approved these changes
Apr 16, 2021
| @@ -978,38 +978,3 @@ func sortStringAlphebeticAscending(s string) string { | |||
| sort.Sort(ss) | |||
| return string([]rune(ss)) | |||
| } | |||
|
|
|||
| func docAsArray(d Document, debug bool) string { | |||
There was a problem hiding this comment.
Nice, removing this in favor of Array.DebugString / Array.String was a good call.
benjirewis
added a commit
that referenced
this pull request
Apr 16, 2021
tsedgwick
pushed a commit
to mongodb-forks/mongo-go-driver
that referenced
this pull request
May 27, 2021
tsedgwick
pushed a commit
to mongodb-forks/mongo-go-driver
that referenced
this pull request
Jun 1, 2021
faem
pushed a commit
to kubedb/mongo-go-driver
that referenced
this pull request
Mar 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GODRIVER-1930
Changes
bsoncore#ReadArray()to return thebsoncore#Arraytype instead of thebsoncore#Documenttype, a change that should have been handled in GODRIVER-1846.This change modifies the return type of
bsoncore#Array()andbsoncore#ArrayOK(), which in turn requires some changes to testing andxlevel code; all small changes 😄 .